fix build for when 'python' is python3#4336
Merged
catamorphism merged 2 commits intorust-lang:incomingfrom Jan 3, 2013
thestinger:python
Merged
fix build for when 'python' is python3#4336catamorphism merged 2 commits intorust-lang:incomingfrom thestinger:python
catamorphism merged 2 commits intorust-lang:incomingfrom
thestinger:python
Conversation
ghost
assigned
Contributor
|
Thanks -- waiting for a try build to run, then I'll merge this. |
Contributor
|
Arch also makes |
catamorphism
added a commit
that referenced
this pull request
Jan 3, 2013
fix build for when 'python' is python3
Contributor
|
Merged, thanks! |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 22, 2025
Automatic Rustup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's also a bonus fix of a shebang that was inconsistent with the others.
It would be really nice if OS X and Debian included the python2 symlink per PEP 394, but sadly that's not the case. The nasty thing about this bug is that it's going to keep coming back as long as those files have a shebang that works on some systems but not others. Testing for this bug is as simple as making the
mk/*.pyfiles non-executable before building - is that something that could be done on the buildbot?