Remove deprecated collections crate.#45446
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 24, 2017
Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
kennytm
added
the
S-waiting-on-review
Member
|
@leodasvacas Looks like Travis is failing here, which is probably because of this line. I think you should just be able to remove collections from there and this should work from there. |
kennytm
added
S-waiting-on-author
leoyvens
force-pushed
the
remove-libcollections
branch
from
bb9b1df to
170f63e
Compare
Contributor
Author
|
@Mark-Simulacrum Thanks, fixed it! |
Member
|
I think this is good to go, but I think we should at least get some signoff from the libs team.. @rust-lang/libs, thoughts? Feel free to run fcp if that's easier (I don't think I can start it). |
kennytm
added
S-waiting-on-review
Member
|
@bors: r+ Thanks! |
Collaborator
|
📌 Commit 170f63e has been approved by |
kennytm
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Oct 24, 2017
Remove deprecated `collections` crate. The real `collections` was merged with `alloc`, this facade was introduced [in this PR](#42720) to give `#[no_std]` users time to adapt. This was done at least two cycles ago, now we can consider removing it for good.
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real
collectionswas merged withalloc, this facade was introduced in this PR to give#[no_std]users time to adapt. This was done at least two cycles ago, now we can consider removing it for good.