Move rustrt::last_os_error into core#4859
Closed
luqmana wants to merge 2 commits intorust-lang:incomingfrom
Closed
Move rustrt::last_os_error into core#4859luqmana wants to merge 2 commits intorust-lang:incomingfrom
luqmana wants to merge 2 commits intorust-lang:incomingfrom
Conversation
Contributor
|
This gives core a dependency on llvm. Right now only rustc has that dependency. r- |
Contributor
Author
|
Alright. Well option 2 now. |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Feb 16, 2026
Automatic Rustup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need for it to be in written anew in rustrt since LLVM already provides a platform independent way of getting the error string. This pull request just makes it available in core::os.
So that's one less helper function in rustrt. (#4812)