Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
Someone the commit message was munged. |
Issue 57762 points out a compiler crash when the compiler was built using a stock LLVM 7. LLVM 7 was released without a necessary fix for a bug in the DWARF discriminant code. This patch changes rustc to use the fallback mode on (non-Rust) LLVM 7. Closes rust-lang#57762
tromey
force-pushed
the
fix-issue-57762
branch
from
f8f386f to
1c95f5a
Compare
Contributor
Author
|
*somehow. apparently I cannot type today. anyway, pushed a better message. |
cuviper
added
beta-nominated
cuviper
reviewed
Jan 22, 2019
nikic
reviewed
Jan 22, 2019
Address the review comments by simplifying the version check to just "< 8".
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 9452a8d has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added
the
T-compiler
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 23, 2019
Fix issue 57762 against a stock LLVM 7. LLVM 7 was released without a necessary fix for a bug in the DWARF discriminant code. This patch changes rustc to use the fallback mode on (non-Rust) LLVM 7. Closes rust-lang#57762
bors
added a commit
that referenced
this pull request
Jan 24, 2019
Rollup of 11 pull requests Successful merges: - #57179 (Update std/lib.rs docs to reflect Rust 2018 usage) - #57730 (Merge visitors in AST validation) - #57779 (Recover from parse errors in literal struct fields and incorrect float literals) - #57793 (Explain type mismatch cause pointing to return type when it is `impl Trait`) - #57795 (Use structured suggestion in stead of notes) - #57817 (Add error for trailing angle brackets.) - #57834 (Stabilize Any::get_type_id and rename to type_id) - #57836 (Fix some cross crate existential type ICEs) - #57840 (Fix issue 57762) - #57844 (use port 80 for retrieving GPG key) - #57858 (Ignore line ending on older git versions) Failed merges: r? @ghost
Collaborator
|
☔ The latest upstream changes (presumably #57869) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Contributor
|
After T-compiler meeting, marking as beta-accepted. |
pnkfelix
added
the
beta-accepted
Contributor
|
Discussed at T-compiler meeting. marking as stable-accepted. In particular, this PR on its own does not warrant a point release, but it is worth including in a hypothetical point release, should one happen. |
pnkfelix
added
the
stable-accepted
emilyalbini
removed
the
beta-nominated
emilyalbini
removed
stable-accepted
Mark-Simulacrum
removed
the
stable-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
against a stock LLVM 7. LLVM 7 was released without a necessary fix
for a bug in the DWARF discriminant code.
This patch changes rustc to use the fallback mode on (non-Rust) LLVM 7.
Closes #57762