ayu theme: Change doccomment color to #a1ac88#74864
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 29, 2020
Merged
Conversation
Contributor
|
Some changes occurred in HTML/CSS/JS. Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire |
rust-highfive
added
the
S-waiting-on-review
tesuji
changed the title
#a1ac88#a1ac88
Co-authored-by: Cldfire <cldfire@3grid.net>
Contributor
|
Thank you! 👍 |
Member
|
If we change the color of doc comments in this theme, we have to do it in all themes. Please do so (I really like the new appearance btw!). |
Contributor
Author
|
Other themes already differ doc comments and non-doc comments by colour. Or do you want to use the same color for doc comments in others? |
Member
|
Oh indeed, my bad! It's change different tones of grey so that's why I thought it was the same. Then it's fine, let's merge this. Thanks! @bors: r+ rollup |
Collaborator
|
📌 Commit 5faef5e has been approved by |
bors
added
S-waiting-on-bors
Contributor
Author
|
The same doc comments color as Dark theme |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 29, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#74266 (Clean up E0720 explanation) - rust-lang#74671 (add const generics array coercion test) - rust-lang#74707 (Add str::[r]split_once) - rust-lang#74814 (Fix RefUnwindSafe & UnwinsSafe impls for lazy::SyncLazy) - rust-lang#74859 (Update outdated readme) - rust-lang#74864 (ayu theme: Change doccomment color to `#a1ac88`) - rust-lang#74872 (Enable to ping RISC-V group via triagebot) - rust-lang#74891 (handle ConstEquate in rustdoc) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Close #74788