[rustdoc] Switch to Symbol for item.name#80044
Conversation
This was always questionable, and removing it doesn't fail any tests, so I think this was not affecting the behavior. It dates all the way back to the very first commit of rustdoc: 268f3f0
jyn514
added
T-rustdoc
This comment has been minimized.
This comment has been minimized.
rust-highfive
added
the
S-waiting-on-review
This decreases the size of `Item` from 680 to 616 bytes. It also does a lot less work since it no longer has to copy as much.
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit a16904f with merge 7ca105dfbe1b53e0dfb4c59e00a8a9defd0f7ea5... |
|
☀️ Try build successful - checks-actions |
|
Queued 7ca105dfbe1b53e0dfb4c59e00a8a9defd0f7ea5 with parent 8b3ee82, future comparison URL. |
|
Finished benchmarking try commit (7ca105dfbe1b53e0dfb4c59e00a8a9defd0f7ea5): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
Max of -0.5% on instruction count, max of -5% on max-rss. So less than I hoped, but definitely worth landing I think. |
|
Thanks! @bors: r+ |
|
📌 Commit a16904f has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Use more symbols in rustdoc Builds on rust-lang#80044 and should not be merged before. I want to test if this is actually faster before merging it, there was a lot of `to_string()` calls so I'm not sure it will actually help. That means I have to wait for 80044 to get merged before running perf. r? `@ghost`
6 participants
This decreases the size of
Itemfrom 680 to 616 bytes. It also does alot less work since it no longer has to copy as much.
Helps with #79103.
r? @GuillaumeGomez