Stabilize str_split_once#81940
Stabilize str_split_once#81940bors merged 1 commit intorust-lang:masterfrom jhpratt:stabilize-str_split_once
Conversation
|
Some changes occured to rustc_codegen_cranelift cc @bjorn3 |
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Error: Label Libs-Small can only be set by Rust team members Please let |
This comment has been minimized.
This comment has been minimized.
|
Error: Label needs-fcp can only be set by Rust team members Please let |
This comment has been minimized.
This comment has been minimized.
|
Error: Label relnotes can only be set by Rust team members Please let |
|
@rustbot modify labels to +T-libs, +A-str Dang it rustbot let me set labels! |
rustbot
added
A-str
This comment has been minimized.
This comment has been minimized.
jonas-schievink
added
the
relnotes
|
Not quite sure why this is failing, as the methods are definitely stabilized here. |
|
tidy tool uses beta toolchain to compile ? |
|
@tesuji If that's the case, why did it build before? |
I'm not certain but one could use RUSTC_BOOTSTRAP flag to enable nightly feature on beta/stable channel. |
|
It does look like we currently globally set RUSTC_BOOTSTRAP for all compilations - I had thought we had stopped doing so for bootstrap compiler only tools, but I guess I just wanted to for long enough that it made it happen. I believe it should be sufficient to just leave the feature gates in for tidy and linkcheck, with a comment having the text cfg(bootstrap) in it above them - I think cfg_attr would be preferable but I'm not 100% sure it will work for the bootstrap tools (it should, though). If it doesn't then just a comment with cfg(bootstrap) on the feature gates is enough. Otherwise it looks like this is good but will need a T-libs FCP, so once we get CI fixed I'll reassign. |
This comment has been minimized.
This comment has been minimized.
|
CI is green. |
m-ou-se
added
S-waiting-on-fcp
|
This is blocked on the FCP on the tracking issue: #74773 (comment) |
|
Based on #74773 (comment) bors r+ |
|
@bors r+ rollup |
|
📌 Commit c28f2a8 has been approved by |
bors
added
the
S-waiting-on-bors
…=m-ou-se Stabilize str_split_once Closes rust-lang#74773
…=m-ou-se Stabilize str_split_once Closes rust-lang#74773
…laumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#81940 (Stabilize str_split_once) - rust-lang#82165 (Reword labels on E0308 involving async fn return type) - rust-lang#82456 (Replaced some unwrap_or and map_or with lazy variants) - rust-lang#82491 (Consider inexpensive inlining criteria first) - rust-lang#82506 (Properly account for non-shorthand pattern field in unused variable lint) - rust-lang#82535 (Set codegen thread names) - rust-lang#82545 (rustdoc: add optional woff2 versions of FiraSans.) - rust-lang#82549 (Revert "Update normalize.css to 8.0.1") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…=m-ou-se Stabilize str_split_once Closes rust-lang#74773
10 participants
Closes #74773