Add docs for shared_from_slice From impls#82041
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 13, 2021
Merged
Conversation
Contributor
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
m-ou-se
reviewed
Feb 12, 2021
Member
m-ou-se
left a comment
m-ou-se
left a comment
There was a problem hiding this comment.
Nice, this is great.
Small nit: Can you put the doc comments above the #[inline] attribute? We usually put the doc comment first and keep the attributes close to the function signature.
The advantage of making these docs is mostly in pointing out that these functions all make new allocations and copy/clone/move the source into them. These docs are on the function, and not the `impl` block, to avoid showing the "[+] show undocumented items" button. CC rust-lang#51430
notriddle
force-pushed
the
shared-from-slice-docs
branch
from
cb23344 to
7fafa4d
Compare
Contributor
Author
|
Okay, the |
Member
|
Thanks! @bors r+ rollup |
Collaborator
|
📌 Commit 7fafa4d has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added
the
T-libs
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#81811 (Fix doc test for Vec::retain(), now passes clippy::eval_order_dependence) - rust-lang#81900 (Organize trait test files) - rust-lang#81995 (Fix suggestion to introduce explicit lifetime) - rust-lang#82031 (Drop an unnecessary intermediate variable) - rust-lang#82033 (Refactor `get_word_attr` to return only `Option`) - rust-lang#82040 (Add test to prevent src link regression) - rust-lang#82041 (Add docs for shared_from_slice From impls) - rust-lang#82050 (Added tests to drain an empty vec) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The advantage of making these docs is mostly in pointing out that these
functions all make new allocations and copy/clone/move the source into them.
These docs are on the function, and not the
implblock, to avoid showingthe "[+] show undocumented items" button.
CC #51430