Hack: Ignore inference variables in certain queries#86866
Merged
bors merged 10 commits intorust-lang:masterfrom Jul 4, 2021
Merged
Hack: Ignore inference variables in certain queries#86866bors merged 10 commits intorust-lang:masterfrom
bors merged 10 commits intorust-lang:masterfrom
Conversation
Contributor
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Jul 4, 2021
oli-obk
reviewed
Jul 4, 2021
Contributor
oli-obk
left a comment
oli-obk
left a comment
There was a problem hiding this comment.
The workaround lgtm, I'll look into opening a tracking issue tomorrow if no one gets to it before me, then you can reference it in the FIXMEs
lqd
reviewed
Jul 4, 2021
Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com>
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@bors r=oli-obk |
Collaborator
|
📌 Commit 492ba34 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
arora-aman
reviewed
Jul 4, 2021
| self.tcx.param_env(closure_def_id.expect_local()), | ||
| )) | ||
| self.tcx | ||
| .type_implements_trait(( |
Contributor
There was a problem hiding this comment.
We use this also in the trait migration part of the code, I think we should do must_apply_modulo_regions there as well
Contributor
There was a problem hiding this comment.
Ignore this, the other method is ty_implements_trait which uses a different query.
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84841
Fixes #86753
Some queries are not built to accept types with inference variables, which can lead to ICEs. These queries probably ought to be converted to canonical form, but as a quick workaround, we can return conservative results in the case that inference variables are found.
We should file a follow-up issue (and update the FIXMEs...) to do the proper refactoring.
cc @arora-aman
r? @oli-obk