boostrap.py use curl by default

[TApplencourt]

Fixes #61611

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

[jyn514]

Please also modify the downloads in src/bootstrap/native.rs to use the same fallback.

[TApplencourt]

Thanks a lot for the quick feedback!

• Fixed python tidy
• Trying to fix native.rs. Sorry for the stupid question, but I was not able to tests my change of native.rs. For python I just did python bootstrap.py. May I ask how to do the same for native.rs? Sorry!

[jyn514]

@TApplencourt you can test the rust changes by setting [llvm] download-ci-llvm = true in config.toml, then making sure it successfully downloads LLVM (just x.py check should do it, or x.py build if you want to be 100% sure rustc_llvm can link to it).

Sorry for the stupid question, but I was not able to tests my change of native.rs

Not a stupid question! Codebases tend to get more complicated over time 😅 it's perfectly fine to ask for help figuring out how they work :)

[Mark-Simulacrum]

Please also keep commits squashed. Thanks!

[TApplencourt]

I think I addressed all the comments. Thanks a lot for the feedback!

I did some checks on my Linux machine; if curl is not present, we will check if we are on windows and if so try the PowerShell way.

I'm not sure about the naming of check_run (the try_run who never aborts). I can change it to any other more descriptive name if needed.

Thanks again for your time and your guidance!

[TApplencourt]

@jyn514, @Mark-Simulacrum If you have time, I think this is ready to review!
Sorry, if I'm too pushy 🙏🏽

[Mark-Simulacrum]

@bors r+

[bors]

📌 Commit ad7dbe1 has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit ad7dbe1 with merge 0be8768...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 0be8768 to master...

[rust-timer]

Finished benchmarking commit (0be8768): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

[TApplencourt]

Thanks a lot y'all for the guidance on this one!

[jyn514]

Thank you for working on it!