Conversation
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@mrMiiao Looking at the errors, it seems like you're missing the stability attributes |
Well, not me... they're missing in std::sys. There's not a one. At all. I really don't know what to do. I'm not such a big person too rewrite std::sys, so I'm here asking for help... Will we never see std::sys as a public module? |
I highly doubt it. The structure of that module keeps changing; if we make it public we can never change it again which would be a problem. This is purely an implementation detail of std. All parts of it that should be public are exposed, e.g., via If there is any specific operation provided by |
|
I agree with @RalfJung |
The oldest occurence is from 9e224c2, which is from the pre-1.0 days. In the years since then, std::sys still hasn't been exported, and the last attempt was met with strong criticism: rust-lang#97151 Thus, removing the "yet" part makes a lot of sense.
Remove "sys isn't exported yet" phrase The oldest occurence is from 9e224c2, which is from the pre-1.0 days. In the years since then, std::sys still hasn't been exported, and the last attempt was met with strong criticism: rust-lang#97151 Thus, removing the "yet" part makes a lot of sense.
The oldest occurence is from 9e224c2bf18ebf8f871efb2e1aba43ed7970ebb7, which is from the pre-1.0 days. In the years since then, std::sys still hasn't been exported, and the last attempt was met with strong criticism: rust-lang/rust#97151 Thus, removing the "yet" part makes a lot of sense.
Remove "sys isn't exported yet" phrase The oldest occurence is from 9e224c2bf18ebf8f871efb2e1aba43ed7970ebb7, which is from the pre-1.0 days. In the years since then, std::sys still hasn't been exported, and the last attempt was met with strong criticism: rust-lang/rust#97151 Thus, removing the "yet" part makes a lot of sense.
"system" unstable feature that allows you to use std::sys module. PR for my issue #97148