Turn on fast_submodules unconditionally#97290
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
left a comment
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
It seems like there could be use cases for this to be on, but I agree turning it off seems likely to be pretty rare.
src/bootstrap/config.rs
Outdated
There was a problem hiding this comment.
It doesn't seem like there's a significant advantage in continuing to accept the option if we're removing it, a hard error seems reasonable to me.
There was a problem hiding this comment.
Sure thing, done. I also added the removal to the changelog (but didn't mark it as a "major change" since I don't think anyone is actually using it).
|
r=me with this as a hard error if still specified @bors delegate+ |
|
✌️ @jyn514 can now approve this pull request |
apiraino
added
the
T-infra
Mark-Simulacrum
added
S-waiting-on-author
I don't know why anyone would turn this off; doing so makes builds much slower (nearly a 60x slowdown according to rust-lang#49057). Remove the option to do so, which makes bootstrap a little easier to maintain. Bootstrap continues to allow you to manage submodules manually by setting `submodules = false`.
|
@bors r=Mark-Simulacrum rollup |
|
@bors r=Mark-Simulacrum |
|
📌 Commit 5df276e has been approved by |
bors
added
S-waiting-on-bors
Rollup of 5 pull requests Successful merges: - rust-lang#97240 (Typo suggestion for a variable with a name similar to struct fields) - rust-lang#97289 (Lifetime variance fixes for clippy) - rust-lang#97290 (Turn on `fast_submodules` unconditionally) - rust-lang#97336 (typo) - rust-lang#97337 (Fix stabilization version of `Ipv6Addr::to_ipv4_mapped`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
7 participants
I don't know why anyone would turn this off; doing so makes builds much slower (nearly a 60x slowdown according to #49057).
Remove the option to do so, which makes bootstrap a little easier to maintain.
Bootstrap continues to allow you to manage submodules manually by setting
submodules = false.