Skip to content

Comments

rustdoc: Add more test coverage#97502

Merged
bors merged 1 commit intorust-lang:masterfrom
onlineSoftwareDevOK:rustdocTests
Jun 3, 2022
Merged

rustdoc: Add more test coverage#97502
bors merged 1 commit intorust-lang:masterfrom
onlineSoftwareDevOK:rustdocTests

Conversation

@onlineSoftwareDevOK
Copy link
Contributor

@onlineSoftwareDevOK onlineSoftwareDevOK commented May 29, 2022

Related issue #91113

@rust-highfive
Copy link
Contributor

rust-highfive commented May 29, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 29, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2022
camelid
camelid reviewed May 29, 2022
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @onlineSoftwareDevOK, thanks for your PR!

I was more thinking that this would test re-exporting private_function a_nested_public_function in a_module and then in the top-level namespace.

However, this test seems useful as well! I left suggestions of how to extend it so it can test some more things too.

Also, could you run rustfmt on this file to fix the indentation? (We use 4 spaces in this repo.)

Feel free to ask for clarification on my comments.

@camelid camelid assigned camelid and unassigned Mark-Simulacrum May 29, 2022
@camelid camelid added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2022
@camelid
Copy link
Member

camelid commented May 29, 2022

By the way, when you're ready for more feedback, please post a comment with the content @rustbot ready. This will mark the PR as ready for another review.

@onlineSoftwareDevOK
Copy link
Contributor Author

onlineSoftwareDevOK commented May 30, 2022

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 30, 2022
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jun 1, 2022

Thanks for working on this! Looks good to me. Do you see anything else @camelid?

GuillaumeGomez
GuillaumeGomez reviewed Jun 1, 2022
View reviewed changes
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jun 2, 2022

Thanks! Please squash your commits then I'll approve it.

@onlineSoftwareDevOK
Copy link
Contributor Author

onlineSoftwareDevOK commented Jun 2, 2022

Thanks! Please squash your commits then I'll approve it.

Done. Thanks in advance!

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jun 2, 2022

Thanks again!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 2, 2022

📌 Commit 9292c90 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 2, 2022
@matthiaskrgr
Rollup merge of rust-lang#97502 - onlineSoftwareDevOK:rustdocTests, r…
7aebfa5 
…=GuillaumeGomez

rustdoc: Add more test coverage

Related issue rust-lang#91113
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 2, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 3, 2022
@bors
Auto merge of rust-lang#97667 - matthiaskrgr:rollup-5cfxc85, r=matthi…
20ad820 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#97502 (rustdoc: Add more test coverage)
 - rust-lang#97627 (update explicit impls error msg)
 - rust-lang#97640 (Fix wrong suggestion for adding where clauses)
 - rust-lang#97645 (don't use a `span_note` for ignored impls)
 - rust-lang#97655 (Improve documentation for constructors of pinned `Box`es)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ba54e75 into rust-lang:master Jun 3, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

@camelid camelid Awaiting requested review from camelid

Assignees

@camelid camelid

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

7 participants

@onlineSoftwareDevOK @rust-highfive @camelid @GuillaumeGomez @bors @Mark-Simulacrum @rustbot