Re-add help_on_error for download-ci-llvm#97519
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
Thanks for tackling this! Can you please squash the commits once you've addressed the review comments? There are instructions at https://rustc-dev-guide.rust-lang.org/git.html#advanced-rebasing.
src/bootstrap/bootstrap.py
Outdated
There was a problem hiding this comment.
Please also remove this from the function parameters (for run, and for all functions which call it, recursively)
src/bootstrap/native.rs
Outdated
There was a problem hiding this comment.
This check looks duplicated - no need to check it twice.
There was a problem hiding this comment.
oops - that was an accident, thanks for the catch!
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
Looks great once you squash the commits, thanks!
Remove dead code Missing } ./x.py fmt Remove duplicate check Recursively remove all usage of help_on_error
spiral-ladder
force-pushed
the
readd-help-on-error
branch
from
a01a055 to
c0f18f9
Compare
|
@bors r=jyn514 |
|
📌 Commit c0f18f9 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 6 pull requests Successful merges: - rust-lang#97494 (Use Box::new() instead of box syntax in library tests) - rust-lang#97499 (Remove "sys isn't exported yet" phrase) - rust-lang#97504 (Ensure source file present when calculating max line number) - rust-lang#97519 (Re-add help_on_error for download-ci-llvm) - rust-lang#97531 (Note pattern mismatch coming from `for` loop desugaring) - rust-lang#97545 (Reword safety comments in core/hash/sip.rs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
7 participants
Closes #97503
help_on_errorfordownload_component()and the downstream functionsbootstrap.pyThanks @jyn514 for the helpful tips!
(first contribution here, please let me know if I missed anything out!)