Skip to content

Comments

Fix file metadata documentation for Windows#97635

Merged
bors merged 1 commit intorust-lang:masterfrom
rgwood:patch-1
Jun 2, 2022
Merged

Fix file metadata documentation for Windows#97635
bors merged 1 commit intorust-lang:masterfrom
rgwood:patch-1

Conversation

@rgwood
Copy link
Contributor

@rgwood rgwood commented Jun 2, 2022

I noticed that the documentation for fs::symlink_metadata() and fs::metadata() is incorrect; the underlying code calls GetFileInformationByHandle() on Windows, not GetFileAttributesEx(). There are currently no uses of GetFileAttributesEx() in this repo.

@rgwood
Fix Windows file metadata docs
0835dfe 
Retrieving file metadata on Windows now uses GetFileInformationByHandle not GetFileAttributesEx
@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 2, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 2, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 2, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2022
@ChrisDenton
Copy link
Member

ChrisDenton commented Jun 2, 2022

Looks like the function was changed a long time ago but the documentation was never updated.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 2, 2022

📌 Commit 0835dfe has been approved by ChrisDenton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 2, 2022
@bors
Auto merge of rust-lang#97644 - Dylan-DPC:rollup-xaeio91, r=Dylan-DPC
9598b4b 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#96894 (Apply track_caller to closure on `expect_non_local()`)
 - rust-lang#97023 (Diagnose anonymous lifetimes errors more uniformly between async and regular fns)
 - rust-lang#97397 (Stabilize `box_into_pin`)
 - rust-lang#97587 (Migrate more diagnostics to use the `#[derive(SessionDiagnostic)]`)
 - rust-lang#97603 (Arc make_mut doc comment spelling correction.)
 - rust-lang#97635 (Fix file metadata documentation for Windows)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fa79247 into rust-lang:master Jun 2, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kennytm kennytm

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

6 participants

@rgwood @rust-highfive @ChrisDenton @bors @kennytm @rustbot