Don't retry infinitely many times on no output#680
Merged
Mark-Simulacrum merged 1 commit intorust-lang:masterfrom Jul 15, 2020
Merged
Don't retry infinitely many times on no output#680Mark-Simulacrum merged 1 commit intorust-lang:masterfrom
Mark-Simulacrum merged 1 commit intorust-lang:masterfrom
Conversation
Example output:
```
[2020-07-06T22:29:20Z WARN collector::execute] failed to deserialize stats, retrying (try 1); output: Output { status: ExitStatus(ExitStatus(0)), stdout: "", stderr: " Documenting issue-20936-deep-vector v0.1.0 (/tmp/.tmpeT8Qdq)\n Finished dev [unoptimized + debuginfo] target(s) in 1.25s\n" }
[2020-07-06T22:29:21Z WARN collector::execute] failed to deserialize stats, retrying (try 2); output: Output { status: ExitStatus(ExitStatus(0)), stdout: "", stderr: " Documenting issue-20936-deep-vector v0.1.0 (/tmp/.tmpeT8Qdq)\n Finished dev [unoptimized + debuginfo] target(s) in 1.19s\n" }
[2020-07-06T22:29:22Z WARN collector::execute] failed to deserialize stats, retrying (try 3); output: Output { status: ExitStatus(ExitStatus(0)), stdout: "", stderr: " Documenting issue-20936-deep-vector v0.1.0 (/tmp/.tmpeT8Qdq)\n Finished dev [unoptimized + debuginfo] target(s) in 1.21s\n" }
[2020-07-06T22:29:23Z WARN collector::execute] failed to deserialize stats, retrying (try 4); output: Output { status: ExitStatus(ExitStatus(0)), stdout: "", stderr: " Documenting issue-20936-deep-vector v0.1.0 (/tmp/.tmpeT8Qdq)\n Finished dev [unoptimized + debuginfo] target(s) in 1.20s\n" }
thread 'main' panicked at 'failed to collect statistics after 5 tries', collector/src/bin/rustc-perf-collector/execute.rs:568:21
```
Member
Author
|
I picked 5 tries arbitrarily, I can make it smaller or bigger if you like. |
Member
Author
|
Looks like a network failure? Or maybe someone deleted their repo? |
Member
|
Yeah I haven't had time to look into that failure, it seems the commit does exist if I manually clone, not sure why Cargo isn't able to get at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example output:
r? @Mark-Simulacrum