Skip to content

Comments

doc(license): make the LICENSE file at the project root readable by pkg.go.dev#126

Merged
samber merged 1 commit intomainfrom
doc/license--pkg-go-dev
Oct 20, 2025
Merged

doc(license): make the LICENSE file at the project root readable by pkg.go.dev#126
samber merged 1 commit intomainfrom
doc/license--pkg-go-dev

Conversation

@samber
Copy link
Owner

@samber samber commented Oct 20, 2025

Fixes #122

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.17%. Comparing base (58b56e8) to head (7a51725).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   69.17%   69.17%           
=======================================
  Files          76       76           
  Lines        9485     9485           
=======================================
  Hits         6561     6561           
  Misses       2839     2839           
  Partials       85       85           
Flag Coverage Δ
unittests 69.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@claude claude bot added documentation Improvements, corrections, or additions to documentation: markdowns, readme, docs/ website.... bug Something isn't working as expected labels Oct 20, 2025
@claude
Copy link

claude bot commented Oct 20, 2025

📋 Review Summary

This PR updates the LICENSE file to make it readable by pkg.go.dev. The changes are straightforward and well-executed.

✅ What's good

  • Clear dual-licensing structure with proper attribution
  • Complete Apache 2.0 license text included
  • Enterprise licensing terms preserved and clarified
  • Production usage definition is comprehensive and clear

🔍 Minor observations

  • The license text is quite long, but this is necessary for pkg.go.dev compatibility
  • No functional code changes, so no risk of breaking changes
  • License format appears to follow Go project conventions

🎯 Recommendation

Approve - This is a documentation-only change that improves license visibility without any functional impact on the codebase.

The PR successfully addresses issue #122 and follows the project's contribution guidelines.

@samber samber merged commit 2928639 into main Oct 20, 2025
23 checks passed
@samber samber deleted the doc/license--pkg-go-dev branch October 20, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected documentation Improvements, corrections, or additions to documentation: markdowns, readme, docs/ website....

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pkg.go.dev: "Documentation not displayed due to license restrictions."

2 participants