Merged
Conversation
…ementType() wherever possible and deprecate everything else; TODO: How to deal with the legacy stuff that got deprecated?
Closed
1 task
…te from it as we need to call it from DTAResolver where we explicitly check for the opaque-pointer condition. Added an entry to the BreakingChanges about the removed IfdsFieldSensTaintAnalysis
MMory
reviewed
Jun 22, 2023
Comment on lines
142
to
+147
| void DTAResolver::otherInst(const llvm::Instruction *Inst) { | ||
| if (Inst->getType()->isOpaquePointerTy()) { | ||
| /// XXX: We may want to get these information on a different way, e.g. by | ||
| /// analyzing the debug info | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
Yes, we may want to add a ticket in the issue board for this
Member
There was a problem hiding this comment.
Agreed. Maybe someone who uses DTA might contribute to fix this. Add to BreakingChanges.md?
lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEGeneralizedLCA/ConstantHelper.cpp
Show resolved
Hide resolved
lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEGeneralizedLCA/EdgeValue.cpp
Show resolved
Hide resolved
lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IDETypeStateAnalysis.cpp
Outdated
Show resolved
Hide resolved
MMory
approved these changes
Aug 2, 2023
Member
MMory
left a comment
MMory
left a comment
There was a problem hiding this comment.
lgtm, what a huge chunk of work 👍
merging will take place at the right moment®
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, PhASAR relies on being able to query pointer-element-types. When moving to LLVM 15, this won't be possible anymore by default (there might be some configuration options to re-enable them for some time, but we should get used to not using them anymore).
This PR removes the dependencies to non-opaque pointers wherever possible without changing the semantics.
For some cases, this is not (easily) possible, so they got marked as
deprecated.