Merged
Conversation
fabianbs96
added
bug
MMory
approved these changes
Apr 20, 2023
Member
MMory
left a comment
MMory
left a comment
There was a problem hiding this comment.
lgtm, thanks!
However, seeing this I wonder whether at some point there could be a preprocessor-free solution. Then, we would not necessarily litter the top-level namespace with some logger identifiers and could do something like psr::IF_LOG_ENABLED_BOOL or so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logger macros
PHASAR_LOG*currently only work if used within the namesapcepsror in an environment that usesusing namespace psr.This PR fixes that issue.