Fix handling of unbalanced returns for IIA#664
Conversation
… solver I am not sure yet how this should be done properly.
include/phasar/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEInstInteractionAnalysis.h
Outdated
Show resolved
Hide resolved
…eractionAnalysis.h Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vulder
left a comment
There was a problem hiding this comment.
From my point of view, this should work. However, I cannot say that removing the isZeroValue check is save.
|
@MMory I suppose this is correct; otherwise we cannot propagate back seed parameters in an unbalanced return, however, I don't know the exact reason for this being introduced (this is already there in Heros). On the other hand, for what use case do you need this? Regarding the null-check on EDIT: The second part may be a separate PR, or what do you think? |
For the change in the IDE solver I am not sure yet how this should be done properly, let's discuss that @fabianbs96