Merged
Conversation
…g if BUILD_PHASAR_CLANG is OFF
Merged
MMory
approved these changes
Feb 29, 2024
Member
MMory
left a comment
MMory
left a comment
There was a problem hiding this comment.
lgtm, good that you discovered and did this, thanks!
| build: [ Debug, Release ] | ||
| include: | ||
| - build: Debug | ||
| flags: -DPHASAR_BUILD_DYNLIB=ON -DPHASAR_ENABLE_SANITIZERS=ON |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cmake option
PHASAR_DEBUG_LIBDEPSdoes not correctly verify that all dependencies are resolved.To fix this, we now use the linker flag
-Wl,-z,defsthat reports a linker error if a library contains unresolved symbols.We also fix dependency errors that were newly discovered by this.