Refactor getAsJson()#725
Merged
fabianbs96 merged 48 commits intosecure-software-engineering:developmentfrom Oct 22, 2024
Merged
Refactor getAsJson()#725fabianbs96 merged 48 commits intosecure-software-engineering:developmentfrom
fabianbs96 merged 48 commits intosecure-software-engineering:developmentfrom
Conversation
* Do not install phasar's dependencies to the global namespace anymore * fix for in-tree build * out-factor the inclusion of LLVM and clang to a separate cmake file * Make PHASAR_CONFIG_INSTALL_DIR respect the CMAKE_INSTALL_PREFIX, even if that is not set at configure time * Fix in-tree build
MMory
approved these changes
Oct 21, 2024
Member
MMory
left a comment
MMory
left a comment
There was a problem hiding this comment.
please fix the minor things before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process to make
nlohmann::jsonand implementation detail (and not having any nlohmann type in our public APIs), we:getAsJson()functionsprintAsJson()functions that should be used instead.