Merged
Conversation
fabianbs96
added
enhancement
…r library dependencies between phasar_llvm_db and phasar_llvm_utils
MMory
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LLVMBasedICFGhas too many tasks and is therefore hard to maintain and violates the single responsibility principle.This PR splits the
LLVMBasedICFGinto three parts: Callgraph-construction (LLVMBasedCallGraphBuilder), global ctors/dtors handling (GlobalCtorsDtorsModel), and representing the LLVM-based ICFG (LLVMBasedICFG). The current API functions fromLLVMBasedICFGare still there for compatibility and convenience.In addition, the callgraph-construction is enhanced to make use of the
Soundnessflag that is already passed in, but not used.Also, callgraph-resolvers that do not modify the alias information, can now communicate this information to the callgraph builder in order to reach a faster path in the fixpoint algorithm.