Pull in the IDESolver++ (aka. IterativeIDESolver)#733
Merged
fabianbs96 merged 12 commits intodevelopmentfrom Nov 10, 2024
Merged
Pull in the IDESolver++ (aka. IterativeIDESolver)#733fabianbs96 merged 12 commits intodevelopmentfrom
fabianbs96 merged 12 commits intodevelopmentfrom
Conversation
The solver is set-up in JF_N configuration from the paper "Scaling Interprocedural Static Data-Flow Analysis to Large C/C++ Applications: An Experience Report"
fabianbs96
added
enhancement
fabianbs96
requested review from
MMory,
pdschubert and
vulder
as code owners
vulder
requested changes
Oct 17, 2024
Collaborator
vulder
left a comment
vulder
left a comment
There was a problem hiding this comment.
Sry, that it took a while. I had a little bit of other stuff to do 🙈
Btw. some of the extras and abstractions look a bit large and complicated overall. I'm not going to comment on the design here in particular. But maybe a few things could be simplified in the future.
unittests/PhasarLLVM/DataFlow/IfdsIde/IterativeIDESolverTest.cpp
Outdated
Show resolved
Hide resolved
unittests/PhasarLLVM/DataFlow/IfdsIde/IterativeIDESolverTest.cpp
Outdated
Show resolved
Hide resolved
include/phasar/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEInstInteractionAnalysis.h
Outdated
Show resolved
Hide resolved
include/phasar/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEInstInteractionAnalysis.h
Show resolved
Hide resolved
vulder
approved these changes
Nov 4, 2024
Collaborator
vulder
left a comment
vulder
left a comment
There was a problem hiding this comment.
Only the 2 small things above left, otherwise this LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the$JF_N$ configuration from the paper "Scaling Interprocedural Static Data-Flow Analysis to Large C/C++ Applications: An Experience Report" (https://doi.org/10.4230/LIPIcs.ECOOP.2024.36).
phasar-clitool