Skip to content

[MergeDups] Use merge sense logic for displayed sense#3324

Merged
imnasnainaec merged 3 commits intomasterfrom
merge-senses-gloss
Aug 28, 2024
Merged

[MergeDups] Use merge sense logic for displayed sense#3324
imnasnainaec merged 3 commits intomasterfrom
merge-senses-gloss

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 23, 2024

Fixes #3318


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend goal: MergeDup labels Aug 23, 2024
@imnasnainaec imnasnainaec self-assigned this Aug 23, 2024
@codecov
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.68%. Comparing base (0804ef9) to head (386afe5).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...rc/goals/MergeDuplicates/Redux/reducerUtilities.ts 86.66% 1 Missing and 1 partial ⚠️
...MergeDuplicates/MergeDupsStep/SenseCardContent.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3324      +/-   ##
==========================================
- Coverage   74.72%   74.68%   -0.05%     
==========================================
  Files         280      280              
  Lines       10734    10744      +10     
  Branches     1296     1298       +2     
==========================================
+ Hits         8021     8024       +3     
- Misses       2349     2354       +5     
- Partials      364      366       +2     
Flag Coverage Δ
backend 83.89% <ø> (-0.11%) ⬇️
frontend 66.67% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 28, 2024 12:55
@imnasnainaec imnasnainaec merged commit 34b59b5 into master Aug 28, 2024
@imnasnainaec imnasnainaec deleted the merge-senses-gloss branch August 28, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend goal: MergeDup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MergeDups] Combining senses doesn't show that glosses will be combined

2 participants