Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3360 +/- ##
==========================================
+ Coverage 74.64% 74.73% +0.08%
==========================================
Files 280 280
Lines 10744 10744
Branches 1298 1298
==========================================
+ Hits 8020 8029 +9
+ Misses 2357 2350 -7
+ Partials 367 365 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
imnasnainaec
approved these changes
Sep 19, 2024
Collaborator
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
andracc
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Generate charts from templates before packaging images * Remove venv tarball from the installer * Update installer README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes improve the standalone installer as follows:
serveroption so that installer can be used to setup a NUC (or other device) running as a server. If theserveroption is specified, then the Combine is configured to start at boot time.Chart.yamlfiles from their templates for all of thehelmcharts before building the packages. Before this change, the installer could only be created from a working directory that had been used to install The Combine previously.This change is