Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3370 +/- ##
==========================================
- Coverage 74.63% 74.59% -0.04%
==========================================
Files 280 280
Lines 10773 10773
Branches 1299 1299
==========================================
- Hits 8040 8036 -4
- Misses 2367 2370 +3
- Partials 366 367 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
imnasnainaec
approved these changes
Sep 27, 2024
Collaborator
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewed 25 of 25 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the "shebang" for Python scripts from:
to
The original shebang was set so that Linux users can run the Python scripts by just providing the script name, e.g.
./deploy/scripts/app_release.py --get.Both of these shebang lines work because the
venvmodule sets uppython3andpythonto point to the version of Python in the virtual environment. However, when thevenvis created on Windows, only thepythonalias is created. This means that the scripts fail when run from aGit Bashsession.The new shebang works for both environments.
This change is