Avoid empty lines in aws profiles list#3387
Merged
imnasnainaec merged 2 commits intomasterfrom Oct 3, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3387 +/- ##
==========================================
+ Coverage 74.64% 74.67% +0.03%
==========================================
Files 280 280
Lines 10773 10773
Branches 1299 1299
==========================================
+ Hits 8041 8045 +4
+ Misses 2367 2363 -4
Partials 365 365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jasonleenaylor
approved these changes
Oct 2, 2024
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
It's good to get out of the rain.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hit an error deploying The Combine because it is possible for the command that lists AWS profiles to have an extra empty line, which results in trying to fetch details for a profile with no name. (Have you every tried to go through the desert on a profile with no name?)
This pr avoids that snag.
This change is