[deploy] Fix helm config and maintenance scripts#3404
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3404 +/- ##
=======================================
Coverage 74.66% 74.66%
=======================================
Files 280 280
Lines 10856 10856
Branches 1317 1317
=======================================
Hits 8106 8106
Misses 2377 2377
Partials 373 373
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This is some fancy bash, I had to look it up. Very effective though. Code quote: if [[ $TAG =~ ^v([0-9]+)\.([0-9]+)\.([0-9]+)-.* ]]; then
VA=${BASH_REMATCH[1]}; VB=${BASH_REMATCH[2]}; VC=${BASH_REMATCH[3]}
if [[ $VC > 0 ]]; then REM="v${VA}\.${VB}\.$((VC - 1))-.*"
elif [[ $VB > 0 ]]; then REM="v${VA}\.$((VB - 1))\..*"
else REM="v$((VA - 1))\..*"; fi |
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 2 of 11 files at r1, 21 of 21 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
deploy_qa.ymlworkflow's step for removing old imagespullSecretNameindeploy/helm/thecombine/values.yamldb_update_audio_type.pypython3shebang in maintenance scriptsThis change is