Skip to content

[DataEntry] Ensure analysis lang is on recent entry notes#3518

Merged
imnasnainaec merged 3 commits intomasterfrom
recent-note-lang
Jan 14, 2025
Merged

[DataEntry] Ensure analysis lang is on recent entry notes#3518
imnasnainaec merged 3 commits intomasterfrom
recent-note-lang

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 14, 2025

Fixes #3517

Acceptance test:

  • Create a project with Backend.Tests/Assets/SingleEntryLiftWithSound.zip
  • Go to Data Entry and select any domain
  • In the Vernacular field, type "testing" and press Tab
  • When the "Select an entry" and "Select a sense" dialogs appear, select the exiting one
  • Once the Gloss field is populated with "what is this", press Enter to submit the word
  • In the new row that appears, add a note
  • Go to project settings and export the project
  • Open the .zip and the contained .lift file
  • Verify that the entry's note has a language (not just an empty string)

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.62%. Comparing base (7a599d0) to head (2d7260c).
Report is 49 commits behind head on master.

Files with missing lines Patch % Lines
src/components/DataEntry/DataEntryTable/index.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3518      +/-   ##
==========================================
- Coverage   74.62%   74.62%   -0.01%     
==========================================
  Files         286      286              
  Lines       11001    11002       +1     
  Branches     1338     1339       +1     
==========================================
  Hits         8210     8210              
- Misses       2408     2409       +1     
  Partials      383      383              
Flag Coverage Δ
backend 83.62% <ø> (ø)
frontend 66.62% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit a4d814b into master Jan 14, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the recent-note-lang branch January 14, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DataEntry] Notes added to recent entry don't have a language

2 participants