[GHA] Update backend and CodeQL endpoints#3522
Merged
imnasnainaec merged 5 commits intomasterfrom Jan 15, 2025
Merged
Conversation
imnasnainaec
added
the
github_actions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3522 +/- ##
==========================================
- Coverage 74.66% 74.62% -0.05%
==========================================
Files 286 286
Lines 11002 11002
Branches 1339 1339
==========================================
- Hits 8215 8210 -5
- Misses 2405 2409 +4
- Partials 382 383 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
imnasnainaec
changed the title
jasonleenaylor
approved these changes
Jan 15, 2025
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CodeQL results were failing to upload (e.g., https://github.com/sillsdev/TheCombine/actions/runs/12777064526/job/35617067435#step:7:486 and https://app.stepsecurity.io/github/sillsdev/TheCombine/actions/runs/12777064526?jobid=35617067435&tab=network-events). Added
uploads.github.com:443to.github/workflows/codeql.ymlto fix that (e.g., https://github.com/sillsdev/TheCombine/actions/runs/12790261713/job/35655616598?pr=3522#step:7:481).Harden Runner is only now handling all the backend/CodeQL_build network events (and still doesn't report the network events of backend/test_build -- see https://app.stepsecurity.io/github/sillsdev/TheCombine/actions/runs/12777064538?jobid=35617067433&tab=network-events). Added the missing endpoint
builds.dotnet.microsoft.com:443to.github/workflows/backend.yml. Also removed superfluous endpointts-crl.ws.symantec.com:80.This change is