Issue#3525: Goal class has unused field: user #3526
Merged
imnasnainaec merged 3 commits intosillsdev:masterfrom Jan 17, 2025
Merged
Issue#3525: Goal class has unused field: user #3526imnasnainaec merged 3 commits intosillsdev:masterfrom
imnasnainaec merged 3 commits intosillsdev:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3526 +/- ##
==========================================
- Coverage 74.55% 66.51% -8.05%
==========================================
Files 286 235 -51
Lines 11022 5844 -5178
Branches 1344 712 -632
==========================================
- Hits 8218 3887 -4331
+ Misses 2417 1729 -688
+ Partials 387 228 -159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Collaborator
|
Thanks for contributing @syamjir. Please delete the 4 lines completely, rather than leaving extra empty lines in their places. |
Contributor
Author
|
@imnasnainaec ,Okay, I will delete those empty lines and submit the pull request shortly. |
imnasnainaec
approved these changes
Jan 17, 2025
Collaborator
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @syamjir)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi sillsdev,
I have removed the user-related properties and imports from the Goal class and simplified the constructor and related code.
Please review the changes and provide any feedback.
Thank you!
Resolves #3525
This change is