Implement all LIFT import fields for better protection#3531
Implement all LIFT import fields for better protection#3531imnasnainaec merged 7 commits intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3531 +/- ##
==========================================
- Coverage 74.51% 74.49% -0.02%
==========================================
Files 285 285
Lines 11013 11025 +12
Branches 1335 1345 +10
==========================================
+ Hits 8206 8213 +7
- Misses 2424 2426 +2
- Partials 383 386 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasonleenaylor
left a comment
There was a problem hiding this comment.
In the context of this PR I can't tell how a protected sense due to pronunciation detail would interact with a user adding audio. I'll try to remember to explore that in QA after merging.
Reviewed 5 of 7 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #1750
Most changes based on https://github.com/sillsdev/FieldWorks/blob/release/9.1/Src/LexText/LexTextControls/LiftMerger.cs
Examples of things from FLEx's LiftMerger that are NOT implemented here:
EntryWasDeletedProcessFieldDefinitionm_*fieldsprivatehelper functionsMakeSafeLiftMultiTextGetOptionalDateTimeGetGuidInExtensibleFillInExtensibleElementsFromRawXmlThis change is