Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3540 +/- ##
==========================================
+ Coverage 74.57% 74.59% +0.02%
==========================================
Files 285 285
Lines 11032 11037 +5
Branches 1341 1342 +1
==========================================
+ Hits 8227 8233 +6
+ Misses 2423 2422 -1
Partials 382 382
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
383278e to
3e48cc9
Compare
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @andracc)
Backend/Otel/OtelKernel.cs line 134 at r1 (raw file):
// In such cases, only add url without IP information to traces. data?.SetTag("url.full", ""); data?.SetTag("url.redacted.ip", LocationProvider.locationGetterUri);
The space at the end of the first comment line and the ? after each data can be removed.
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @andracc)
Follow-up on #3538 in resolving #3534
This change is