Skip to content

[Otel] Redact IP info from tags#3540

Merged
andracc merged 2 commits intomasterfrom
otel/redact-ip
Jan 27, 2025
Merged

[Otel] Redact IP info from tags#3540
andracc merged 2 commits intomasterfrom
otel/redact-ip

Conversation

@andracc
Copy link
Collaborator

@andracc andracc commented Jan 27, 2025

Follow-up on #3538 in resolving #3534

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.59%. Comparing base (ed63507) to head (e6f6343).
Report is 34 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3540      +/-   ##
==========================================
+ Coverage   74.57%   74.59%   +0.02%     
==========================================
  Files         285      285              
  Lines       11032    11037       +5     
  Branches     1341     1342       +1     
==========================================
+ Hits         8227     8233       +6     
+ Misses       2423     2422       -1     
  Partials      382      382              
Flag Coverage Δ
backend 83.89% <100.00%> (+0.03%) ⬆️
frontend 66.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andracc andracc changed the title [Otel] Redact IP info and add dev location [Otel] Redact IP info from tags Jan 27, 2025
@andracc andracc self-assigned this Jan 27, 2025
@andracc andracc requested a review from imnasnainaec January 27, 2025 21:39
Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @andracc)


Backend/Otel/OtelKernel.cs line 134 at r1 (raw file):

                        // In such cases, only add url without IP information to traces.
                        data?.SetTag("url.full", "");
                        data?.SetTag("url.redacted.ip", LocationProvider.locationGetterUri);

The space at the end of the first comment line and the ? after each data can be removed.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andracc)

@imnasnainaec imnasnainaec added backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. bug Something isn't working and removed maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Jan 27, 2025
@andracc andracc merged commit 74feaaa into master Jan 27, 2025
18 checks passed
@andracc andracc deleted the otel/redact-ip branch January 27, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants