Skip to content

[MergeDups] Fix bug preventing use of extra column#3548

Merged
imnasnainaec merged 1 commit intomasterfrom
merge-new-word
Jan 28, 2025
Merged

[MergeDups] Fix bug preventing use of extra column#3548
imnasnainaec merged 1 commit intomasterfrom
merge-new-word

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 28, 2025

Fixes #3546


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend goal: MergeDup labels Jan 28, 2025
@imnasnainaec imnasnainaec requested a review from andracc January 28, 2025 20:02
@imnasnainaec imnasnainaec self-assigned this Jan 28, 2025
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) January 28, 2025 20:07
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.54%. Comparing base (74feaaa) to head (2f5e3d7).
Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
...rc/goals/MergeDuplicates/Redux/MergeDupsReducer.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3548      +/-   ##
==========================================
- Coverage   74.61%   74.54%   -0.08%     
==========================================
  Files         285      285              
  Lines       11037    11037              
  Branches     1342     1343       +1     
==========================================
- Hits         8235     8227       -8     
- Misses       2421     2426       +5     
- Partials      381      384       +3     
Flag Coverage Δ
backend 83.79% <ø> (-0.14%) ⬇️
frontend 66.32% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec merged commit 976c1f8 into master Jan 28, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the merge-new-word branch January 28, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend goal: MergeDup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MergeDups] Cannot use blank column

2 participants

Comments