[AudioRecorder] Fix bug preventing multiple recordings#3556
Merged
imnasnainaec merged 4 commits intomasterfrom Jan 31, 2025
Merged
[AudioRecorder] Fix bug preventing multiple recordings#3556imnasnainaec merged 4 commits intomasterfrom
imnasnainaec merged 4 commits intomasterfrom
Conversation
imnasnainaec
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3556 +/- ##
==========================================
- Coverage 74.50% 74.49% -0.01%
==========================================
Files 285 285
Lines 11005 11007 +2
Branches 1332 1333 +1
==========================================
+ Hits 8199 8200 +1
- Misses 2423 2424 +1
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andracc
approved these changes
Jan 31, 2025
Collaborator
andracc
left a comment
andracc
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3555
To test, try various combinations of adding and removing recording in Data Entry (on both New and Recent entries) and in Review Entries (both in the pronunciation column of the main table and in a row's Edit Dialog).
This change is