Skip to content

[ReviewEntries] Eliminate unhandled edit error#3595

Merged
imnasnainaec merged 1 commit intomasterfrom
edit-uncaught-err
Feb 3, 2025
Merged

[ReviewEntries] Eliminate unhandled edit error#3595
imnasnainaec merged 1 commit intomasterfrom
edit-uncaught-err

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 3, 2025

This change is Reviewable

@imnasnainaec imnasnainaec requested a review from andracc February 3, 2025 19:31
@imnasnainaec imnasnainaec self-assigned this Feb 3, 2025
@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.50%. Comparing base (2fad544) to head (c4da52b).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
...s/ReviewEntriesTable/Cells/EditCell/EditDialog.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3595      +/-   ##
==========================================
+ Coverage   74.46%   74.50%   +0.03%     
==========================================
  Files         285      285              
  Lines       11013    11013              
  Branches     1335     1335              
==========================================
+ Hits         8201     8205       +4     
+ Misses       2428     2425       -3     
+ Partials      384      383       -1     
Flag Coverage Δ
backend 83.77% <ø> (+0.07%) ⬆️
frontend 66.33% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) February 3, 2025 19:37
@imnasnainaec imnasnainaec merged commit cae954f into master Feb 3, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the edit-uncaught-err branch February 3, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants