Skip to content

[SiteSettings] Fix project roles dialog title#3600

Merged
imnasnainaec merged 2 commits intomasterfrom
site-settings-proj-roles
Feb 13, 2025
Merged

[SiteSettings] Fix project roles dialog title#3600
imnasnainaec merged 2 commits intomasterfrom
site-settings-proj-roles

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 4, 2025

Fixes #3599


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend labels Feb 4, 2025
@imnasnainaec imnasnainaec self-assigned this Feb 4, 2025
@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.38%. Comparing base (e185a5d) to head (89e03c9).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
...tManagement/ProjectUsersButtonWithConfirmation.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3600   +/-   ##
=======================================
  Coverage   74.38%   74.38%           
=======================================
  Files         285      285           
  Lines       11057    11057           
  Branches     1350     1350           
=======================================
  Hits         8225     8225           
  Misses       2445     2445           
  Partials      387      387           
Flag Coverage Δ
backend 83.72% <ø> (∅)
frontend 66.18% <0.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 48d059d into master Feb 13, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the site-settings-proj-roles branch February 13, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SiteSettings>ProjectManagement] Project roles dialog console error

2 participants