Skip to content

Pause user analytics during login/signup#3621

Merged
andracc merged 9 commits intomasterfrom
otel/login
Feb 27, 2025
Merged

Pause user analytics during login/signup#3621
andracc merged 9 commits intomasterfrom
otel/login

Conversation

@andracc
Copy link
Collaborator

@andracc andracc commented Feb 24, 2025

Resolves #3606

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.43%. Comparing base (2c93236) to head (f7e599e).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3621      +/-   ##
==========================================
- Coverage   74.43%   74.43%   -0.01%     
==========================================
  Files         284      284              
  Lines       11054    11053       -1     
  Branches     1356     1355       -1     
==========================================
- Hits         8228     8227       -1     
  Misses       2434     2434              
  Partials      392      392              
Flag Coverage Δ
backend 83.87% <100.00%> (-0.01%) ⬇️
frontend 66.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andracc andracc marked this pull request as ready for review February 27, 2025 19:17
Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andracc)

@andracc andracc merged commit 77d82a5 into master Feb 27, 2025
18 checks passed
@andracc andracc deleted the otel/login branch February 27, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[analytics] Don't get user analytics with login/signup

2 participants