Skip to content

[ProjectExport] Fix download file name and errors#3622

Merged
imnasnainaec merged 4 commits intomasterfrom
download-err
Feb 25, 2025
Merged

[ProjectExport] Fix download file name and errors#3622
imnasnainaec merged 4 commits intomasterfrom
download-err

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 25, 2025

Fixes #3323

Also fixes issue where the downloaded .zip file is supposed to have a file name generated from the project name (#2115) but it didn't.


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend import/export labels Feb 25, 2025
@imnasnainaec imnasnainaec self-assigned this Feb 25, 2025
@imnasnainaec imnasnainaec changed the title Download err [ProjectExport] Fix download file name and errors Feb 25, 2025
@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 74.43%. Comparing base (5a4d614) to head (ed937c6).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
src/components/ProjectExport/DownloadButton.tsx 21.05% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3622      +/-   ##
==========================================
- Coverage   74.45%   74.43%   -0.03%     
==========================================
  Files         284      284              
  Lines       11048    11054       +6     
  Branches     1354     1356       +2     
==========================================
+ Hits         8226     8228       +2     
- Misses       2431     2434       +3     
- Partials      391      392       +1     
Flag Coverage Δ
backend 83.88% <ø> (ø)
frontend 66.13% <21.05%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) February 25, 2025 19:27
@imnasnainaec imnasnainaec merged commit fdfb6a8 into master Feb 25, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the download-err branch February 25, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend import/export

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On Firefox, false Export error

2 participants