Skip to content

[NewEntry>VernDialog] If only one entry, auto-expand senses#3625

Merged
imnasnainaec merged 4 commits intomasterfrom
dup-vern-auto-expand
Feb 27, 2025
Merged

[NewEntry>VernDialog] If only one entry, auto-expand senses#3625
imnasnainaec merged 4 commits intomasterfrom
dup-vern-auto-expand

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 26, 2025

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.43%. Comparing base (77d82a5) to head (b66399a).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...s/DataEntry/DataEntryTable/NewEntry/VernDialog.tsx 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3625      +/-   ##
==========================================
- Coverage   74.43%   74.43%   -0.01%     
==========================================
  Files         284      284              
  Lines       11053    11056       +3     
  Branches     1355     1357       +2     
==========================================
+ Hits         8227     8229       +2     
  Misses       2434     2434              
- Partials      392      393       +1     
Flag Coverage Δ
backend 83.87% <ø> (ø)
frontend 66.14% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec marked this pull request as ready for review February 26, 2025 20:29
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) February 27, 2025 21:16
@imnasnainaec imnasnainaec merged commit b1f3ebe into master Feb 27, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the dup-vern-auto-expand branch February 27, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants