[frontend] Fix left/right to work with rtl#3671
Conversation
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 30 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
src/goals/CharacterInventory/CharInv/CharacterList/CharacterCard.tsx line 33 at r1 (raw file):
style={{ height: props.fontHeight, marginLeft: theme.spacing(1),
This marginLeft is intentionally dropped (rather than replaced with marginInlineStart) because it puts the character off-center.
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3671 +/- ##
==========================================
- Coverage 73.26% 73.25% -0.01%
==========================================
Files 285 285
Lines 10627 10631 +4
Branches 1321 1323 +2
==========================================
+ Hits 7786 7788 +2
Misses 2451 2451
- Partials 390 392 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 29 of 30 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
Fixes #3604
This change is