Skip to content

[frontend] Fix left/right to work with rtl#3671

Merged
imnasnainaec merged 4 commits intomasterfrom
left-right
Mar 24, 2025
Merged

[frontend] Fix left/right to work with rtl#3671
imnasnainaec merged 4 commits intomasterfrom
left-right

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Mar 12, 2025

Fixes #3604


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend font/language labels Mar 12, 2025
@imnasnainaec imnasnainaec self-assigned this Mar 12, 2025
Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 30 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)


src/goals/CharacterInventory/CharInv/CharacterList/CharacterCard.tsx line 33 at r1 (raw file):

          style={{
            height: props.fontHeight,
            marginLeft: theme.spacing(1),

This marginLeft is intentionally dropped (rather than replaced with marginInlineStart) because it puts the character off-center.

@imnasnainaec

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.25%. Comparing base (dbb3cf9) to head (7020a4f).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
src/components/AppBar/SpeakerMenu.tsx 0.00% 0 Missing and 1 partial ⚠️
src/components/AppBar/UserMenu.tsx 50.00% 0 Missing and 1 partial ⚠️
src/components/Dialogs/DeleteEditTextDialog.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3671      +/-   ##
==========================================
- Coverage   73.26%   73.25%   -0.01%     
==========================================
  Files         285      285              
  Lines       10627    10631       +4     
  Branches     1321     1323       +2     
==========================================
+ Hits         7786     7788       +2     
  Misses       2451     2451              
- Partials      390      392       +2     
Flag Coverage Δ
backend 82.81% <ø> (ø)
frontend 65.77% <40.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 29 of 30 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 3a47004 into master Mar 24, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the left-right branch March 24, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working font/language frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicit left/right styles not adapted for RTL UI

2 participants