Skip to content

Allow login with email address#3673

Merged
imnasnainaec merged 8 commits intomasterfrom
login-email
Mar 19, 2025
Merged

Allow login with email address#3673
imnasnainaec merged 8 commits intomasterfrom
login-email

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Mar 13, 2025

Resolves #3608

Also add more safeguards against collision of one user's username with another user's email address.

Acceptance tests:

  • Create a user (A) with a username different than the email address

    • Log in with the username
    • Log in with the email address
    • Try to create a second user (B) with username that matches the email address of the first user (A)
      • See error message: Username not available.
  • Create a user (C) with a valid email address as the username and a fake email address for the email address

    • Try to create a user (D) with email address that matches the username of another user (C)
      • See error message: Email address not available.
    • Log in to a user with an email address for a username (C) and in User Settings, update the email address to match the username

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.26%. Comparing base (e663ff9) to head (70151e7).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
Backend/Controllers/UserController.cs 66.66% 3 Missing and 1 partial ⚠️
Backend/Services/PermissionService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3673   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files         285      285           
  Lines       10627    10627           
  Branches     1322     1321    -1     
=======================================
  Hits         7786     7786           
  Misses       2451     2451           
  Partials      390      390           
Flag Coverage Δ
backend 82.81% <66.66%> (+<0.01%) ⬆️
frontend 65.78% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec marked this pull request as ready for review March 14, 2025 17:54
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 14 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) March 19, 2025 18:34
@imnasnainaec imnasnainaec merged commit dbb3cf9 into master Mar 19, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the login-email branch March 19, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login form should accept email address as user identifier

2 participants