Skip to content

[LIFT] Support export/import of entry flags#3677

Merged
imnasnainaec merged 14 commits intomasterfrom
flag2
Apr 21, 2025
Merged

[LIFT] Support export/import of entry flags#3677
imnasnainaec merged 14 commits intomasterfrom
flag2

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Mar 21, 2025

Resolves #3264
Depends sillsdev/libpalaso#1414

Also, drops Backend LIFT support of entry Plural, which is otherwise unsupported.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Mar 21, 2025
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 73.18%. Comparing base (d09ce63) to head (17a2970).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
Backend/Services/LiftService.cs 52.63% 15 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3677      +/-   ##
==========================================
- Coverage   73.32%   73.18%   -0.15%     
==========================================
  Files         285      285              
  Lines       10656    10673      +17     
  Branches     1327     1332       +5     
==========================================
- Hits         7814     7811       -3     
- Misses       2450     2467      +17     
- Partials      392      395       +3     
Flag Coverage Δ
backend 82.46% <60.00%> (-0.37%) ⬇️
frontend 65.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec marked this pull request as ready for review April 15, 2025 13:56
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit dd871d5 into master Apr 21, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the flag2 branch April 21, 2025 17:49
andracc pushed a commit that referenced this pull request Apr 22, 2025
Also, drop Backend LIFT support of entry field Plural, which is otherwise unsupported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Export] Include flags

2 participants