Update spell-check dictionaries#3717
Merged
imnasnainaec merged 12 commits intomasterfrom Apr 16, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3717 +/- ##
=======================================
Coverage 73.32% 73.32%
=======================================
Files 285 285
Lines 10654 10656 +2
Branches 1327 1327
=======================================
+ Hits 7812 7814 +2
Misses 2450 2450
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andracc
approved these changes
Apr 16, 2025
Collaborator
andracc
left a comment
andracc
left a comment
There was a problem hiding this comment.
Reviewed 52 of 117 files at r1, 101 of 101 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
andracc
pushed a commit
that referenced
this pull request
Apr 22, 2025
The dictionary for Hindi (hi) has grown a lot since this was last done, so dropped the custom threshold adjustment (changing from -t 1000 to the default -t 2000) and added a max word-length (-m 6) to keep the updated src/resources/dictionaries/hi down to 2.4 MB. The Spanish (es) dictionary has shrunk a bit, so added a custom threshold (from default -T 20000 to -T 15000) to maintain some of the file splitting. Dropped numeral support, to clear noisy entries, especially in the French (fr) wordlist. Switched from NFKD to NFD normalization to allow for unexpected characters and to match #3718.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dictionary for Hindi (
hi) has grown a lot since this was last done, so dropped the custom threshold adjustment (changing from-t 1000to the default-t 2000) and added a max word-length (-m 6) to keep the updatedsrc/resources/dictionaries/hidown to 2.4 MB.The Spanish (
es) dictionary has shrunk a bit, so added a custom threshold (from default-T 20000to-T 15000) to maintain some of the file splitting.Dropped numeral support, to clear noisy entries, especially in the French (
fr) wordlist.Switched from NFKD to NFD normalization to allow for unexpected characters and to match #3718.
This change is