Skip to content

[ReviewEntries] Use localeCompare for all text column sorts#3724

Merged
imnasnainaec merged 1 commit intomasterfrom
locale-compare
Apr 15, 2025
Merged

[ReviewEntries] Use localeCompare for all text column sorts#3724
imnasnainaec merged 1 commit intomasterfrom
locale-compare

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 15, 2025

Fixes #3723


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.32%. Comparing base (454c1ae) to head (aeb88fa).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3724      +/-   ##
==========================================
+ Coverage   73.30%   73.32%   +0.02%     
==========================================
  Files         285      285              
  Lines       10646    10654       +8     
  Branches     1327     1327              
==========================================
+ Hits         7804     7812       +8     
  Misses       2450     2450              
  Partials      392      392              
Flag Coverage Δ
backend 82.83% <ø> (ø)
frontend 65.90% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 4a6f4d5 into master Apr 15, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the locale-compare branch April 15, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ReviewEntries] Column sorting should be with localeCompare

2 participants