Skip to content

[MergeDups] Make gloss and definition merging more uniform#3743

Merged
imnasnainaec merged 3 commits intomasterfrom
merge-gloss
May 6, 2025
Merged

[MergeDups] Make gloss and definition merging more uniform#3743
imnasnainaec merged 3 commits intomasterfrom
merge-gloss

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 23, 2025

Resolves #3742


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.83%. Comparing base (4e22884) to head (36678c3).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3743      +/-   ##
==========================================
+ Coverage   72.81%   72.83%   +0.02%     
==========================================
  Files         287      287              
  Lines       10707    10701       -6     
  Branches     1334     1330       -4     
==========================================
- Hits         7796     7794       -2     
+ Misses       2514     2512       -2     
+ Partials      397      395       -2     
Flag Coverage Δ
backend 81.83% <ø> (ø)
frontend 65.78% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec marked this pull request as ready for review April 25, 2025 17:31
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit c3dd452 into master May 6, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the merge-gloss branch May 6, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MergeDups] Merging of gloss/definition is asymmetric

2 participants