Skip to content

Migrate more frontend tests to @testing-library#3749

Merged
imnasnainaec merged 9 commits intomasterfrom
test-instance-has-text
May 13, 2025
Merged

Migrate more frontend tests to @testing-library#3749
imnasnainaec merged 9 commits intomasterfrom
test-instance-has-text

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 25, 2025

More of #3180


This change is Reviewable

@imnasnainaec imnasnainaec added frontend test lowpriority This issue might not be worked on labels Apr 25, 2025
@imnasnainaec imnasnainaec self-assigned this Apr 25, 2025
@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.82%. Comparing base (bbf2f1d) to head (d6a26af).
Report is 47 commits behind head on master.

Files with missing lines Patch % Lines
src/components/ProjectScreen/ChooseProject.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3749      +/-   ##
==========================================
- Coverage   72.84%   72.82%   -0.03%     
==========================================
  Files         287      286       -1     
  Lines       10725    10716       -9     
  Branches     1331     1330       -1     
==========================================
- Hits         7813     7804       -9     
  Misses       2517     2517              
  Partials      395      395              
Flag Coverage Δ
backend 81.83% <ø> (ø)
frontend 65.75% <80.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec enabled auto-merge (squash) May 8, 2025 16:16
@imnasnainaec imnasnainaec requested a review from andracc May 8, 2025 18:10
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 13 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit fa6bb7b into master May 13, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the test-instance-has-text branch May 13, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend lowpriority This issue might not be worked on test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants