Skip to content

Allow apostrophe in file names#3804

Merged
imnasnainaec merged 2 commits intomasterfrom
apostrophe
May 19, 2025
Merged

Allow apostrophe in file names#3804
imnasnainaec merged 2 commits intomasterfrom
apostrophe

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented May 19, 2025

Resolves #3799


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this May 19, 2025
@imnasnainaec imnasnainaec added bug Something isn't working backend audio labels May 19, 2025
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.88%. Comparing base (9697905) to head (e448bc8).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3804      +/-   ##
==========================================
+ Coverage   65.73%   72.88%   +7.14%     
==========================================
  Files         235      286      +51     
  Lines        6001    10738    +4737     
  Branches      747     1335     +588     
==========================================
+ Hits         3945     7826    +3881     
- Misses       1815     2515     +700     
- Partials      241      397     +156     
Flag Coverage Δ
backend 81.92% <100.00%> (?)
frontend 65.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit a9810fb into master May 19, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the apostrophe branch May 19, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audio backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate 415 errors with GET v1/projects/{projectId}/words/{wordId}/audio/download/{fileName}

2 participants