Skip to content

[Backend.Tests] Change sealed internal to internal sealed#3833

Merged
imnasnainaec merged 1 commit intomasterfrom
sealed
Jun 3, 2025
Merged

[Backend.Tests] Change sealed internal to internal sealed#3833
imnasnainaec merged 1 commit intomasterfrom
sealed

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 2, 2025

Match our usage of public sealed and private sealed.
Also remove unnecessary empty exception constructors.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 2, 2025
@imnasnainaec imnasnainaec added backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Jun 2, 2025
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.92%. Comparing base (8c6b909) to head (3066e9c).
⚠️ Report is 39 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3833   +/-   ##
=======================================
  Coverage   72.92%   72.92%           
=======================================
  Files         286      286           
  Lines       10771    10768    -3     
  Branches     1340     1340           
=======================================
- Hits         7855     7853    -2     
+ Misses       2516     2515    -1     
  Partials      400      400           
Flag Coverage Δ
backend 81.92% <ø> (+<0.01%) ⬆️
frontend 65.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec changed the title [Backend] Change sealed internal to internal sealed [Backend.Tests] Change sealed internal to internal sealed Jun 3, 2025
Copy link

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 4a8dcce into master Jun 3, 2025
24 of 27 checks passed
@imnasnainaec imnasnainaec deleted the sealed branch June 3, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants